fix(rsc): exclude CSS imports with special queries from automatic injection #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSS imports with special queries (?url, ?inline, ?raw) should not be collected for server-side rendering as they return strings rather than applying styles. This fix adds a hasSpecialCssQuery() helper function to detect and exclude these imports from the collectCss function, preventing unexpected behavior while ensuring normal CSS imports continue to work correctly. - Add hasSpecialCssQuery() helper to detect ?url, ?inline, ?raw queries - Modify collectCss() to exclude CSS imports with special queries - Add comprehensive e2e tests for both server and client components - Test all query patterns with separate CSS files to ensure proper handling Fixes #571 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
hi-ogawa
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where CSS imports with special queries (?url, ?inline, ?raw) were being incorrectly collected for server-side rendering, causing unexpected behavior since these queries return strings rather than applying styles.
- Add
hasSpecialCssQuery()helper function to detect CSS imports with special queries - Modify
collectCss()to exclude CSS imports with special queries from automatic injection - Add comprehensive e2e tests covering both server and client components with all query patterns
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/plugin-rsc/src/plugin.ts | Core fix: adds helper function and excludes special CSS queries from collection |
| packages/plugin-rsc/examples/basic/src/server.tsx | Updates CSP to allow inline styles for testing |
| packages/plugin-rsc/examples/basic/src/routes/root.tsx | Integrates new CSS queries test component |
| packages/plugin-rsc/examples/basic/src/routes/css-queries/* | Test files for CSS query functionality on both server and client |
| packages/plugin-rsc/e2e/basic.test.ts | E2e test verifying CSS queries are not auto-injected but work when manually applied |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/plugin-rsc/examples/basic/src/routes/css-queries/client.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS imports with special queries (?url, ?inline, ?raw) should not be collected for server-side rendering as they return strings rather than applying styles.
This fix adds a hasSpecialCssQuery() helper function to detect and exclude these imports from the collectCss function, preventing unexpected behavior while ensuring normal CSS imports continue to work correctly.
Fixes #571
🤖 Generated with Claude Code
Description